Skip to content

perf(workflow): Implement result cache for IP checks#62039

Merged
nickvergessen merged 4 commits into
masterfrom
bugfix/noid/improve-performance-of-checks
Jul 13, 2026
Merged

perf(workflow): Implement result cache for IP checks#62039
nickvergessen merged 4 commits into
masterfrom
bugfix/noid/improve-performance-of-checks

Conversation

@nickvergessen

@nickvergessen nickvergessen commented Jul 13, 2026

Copy link
Copy Markdown
Member

Summary

  • When the workflows are checked hundreds/thousands of times in the same request, the IP address as well as the time are not changing, so we can simply cache the result on a per operation+value level

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@nickvergessen
perf(workflow): Implement result cache for IP checks
21d7937 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
perf(workflows): Fix cache in request time check
75a6822 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
chore(workflow): Simplify code in URL check
c0f8fa8 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 35 milestone Jul 13, 2026
@nickvergessen nickvergessen self-assigned this Jul 13, 2026
@nickvergessen nickvergessen requested a review from blizzz as a code owner July 13, 2026 07:32
@nickvergessen

nickvergessen commented Jul 13, 2026

Copy link
Copy Markdown
Member Author

/backport to stable34

@nickvergessen

nickvergessen commented Jul 13, 2026

Copy link
Copy Markdown
Member Author

/backport to stable33

@nickvergessen

nickvergessen commented Jul 13, 2026

Copy link
Copy Markdown
Member Author

/backport to stable32

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 13, 2026
come-nc
come-nc requested changes Jul 13, 2026
View reviewed changes
Comment thread apps/workflowengine/lib/Check/RequestRemoteAddress.php Outdated
@nickvergessen
chore(workflows): Migrate to CappedMemoryCache
e7004a5 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen requested a review from come-nc July 13, 2026 09:10
@nickvergessen nickvergessen merged commit 5d6a26e into master Jul 13, 2026
189 of 196 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/improve-performance-of-checks branch July 13, 2026 11:39
This was referenced Jul 13, 2026
Open
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes
@CarlSchwan CarlSchwan CarlSchwan approved these changes
@provokateurin provokateurin provokateurin approved these changes
@SystemKeeper SystemKeeper Awaiting requested review from SystemKeeper
@blizzz blizzz Awaiting requested review from blizzz blizzz is a code owner
@come-nc come-nc Awaiting requested review from come-nc

Assignees

@nickvergessen nickvergessen

Labels

4. to release Ready to be released and/or waiting for tests to finish feature: workflows performance 🚀

Projects

None yet

Milestone

Nextcloud 35

Development

Successfully merging this pull request may close these issues.

5 participants

@nickvergessen @ChristophWurst @CarlSchwan @provokateurin @come-nc