Skip to content

fix(KeyValueCache): allow negative TTL for file locking #62114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 1 commit into from
Jul 15, 2026
+1 −1
Merged

fix(KeyValueCache): allow negative TTL for file locking #62114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/private/Memcache/KeyValueCache.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ protected function evalLua(string $scriptName, array $keys, array $args) {
* so fall back to the default and cap it to the maximum.
*/
private function normalizeTtl(int $ttl): int {
if ($ttl <= 0) {
if ($ttl === 0) { // we need to allow negative TTL for file locking
$ttl = self::DEFAULT_TTL;
}
return min($ttl, self::MAX_TTL);
Expand Down
Loading