Skip to content

[stable29] fix(preview): properly handle encoded content#62267

Merged
nickvergessen merged 3 commits into
stable29from
backport/62202/stable29
Jul 21, 2026
Merged

[stable29] fix(preview): properly handle encoded content#62267
nickvergessen merged 3 commits into
stable29from
backport/62202/stable29

Conversation

@backportbot

@backportbot backportbot Bot commented Jul 17, 2026

Copy link
Copy Markdown

Backport of PR #62202

@susnux @backportbot
fix(preview): properly handle encoded content
cc5b840 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@backportbot
backportbot Bot requested review from AndyScherzinger and susnux July 17, 2026 14:11
@susnux susnux changed the title [stable29] [stable30] fix(preview): properly handle encoded content [stable29] fix(preview): properly handle encoded content Jul 17, 2026
@susnux susnux self-assigned this Jul 17, 2026
@susnux
chore: adjust for old PHP
85c46ae 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@nickvergessen

nickvergessen commented Jul 21, 2026

Copy link
Copy Markdown
Member

There were 5 failures:

  1. Test\Preview\HEICTest::testGetThumbnail with data set #0 (-81, -72)
    Failed asserting that null is not equal to false.

/home/runner/work/server/server/tests/lib/Preview/Provider.php:152
/home/runner/work/server/server/tests/lib/Preview/Provider.php:107

@nickvergessen

nickvergessen commented Jul 21, 2026

Copy link
Copy Markdown
Member

Ah also fails on stable29

@nickvergessen

nickvergessen commented Jul 21, 2026

Copy link
Copy Markdown
Member

But:

5) Test\Preview\SVGTest::testGetThumbnailSvgEncoded with data set "iso-2022-jp" ('<?xml version="1.0" encoding=...</svg>')
Failed asserting that OCP\Image Object &000000000231aa12000000007076a520 (
    'resource' => GdImage Object &000000000231aa3a000000007076a520 ()

is related

@susnux
fix(Preview): reorder encodings for detection
eede98a 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@nickvergessen
nickvergessen merged commit dacd3f7 into stable29 Jul 21, 2026
175 of 182 checks passed
@nickvergessen
nickvergessen deleted the backport/62202/stable29 branch July 21, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes
@susnux susnux susnux approved these changes
@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger

Assignees

@susnux susnux

Labels

3. to review Waiting for reviews bug feature: previews and thumbnails

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nickvergessen @susnux