Allow to close sidebar for text files#6499
Merged
Merged
Conversation
* the close button was overlapped by the text preview and you could not close the sidebar then Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
requested review from
jancborchardt,
juliusknorr,
nickvergessen,
rullzer and
skjnldsv
|
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @PVince81 and @jancborchardt to be potential reviewers. |
Member
|
Can't reproduce. |
Member
Author
Master. Without:
With this patch:
|
skjnldsv
approved these changes
Sep 14, 2017
skjnldsv
left a comment
skjnldsv
left a comment
Member
There was a problem hiding this comment.
Still can't reproduce, but this change can't harm the overall ui.
Member
Author
|
Backport is in #6525 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @nextcloud/designers