Fix missing "unsigned" on integer columns#6564
Merged
Merged
Conversation
nickvergessen
added
3. to review
LukasReschke
approved these changes
Sep 19, 2017
MorrisJobke
approved these changes
Sep 19, 2017
MorrisJobke
added
4. to release
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
fix-missing-unsigned
branch
from
cd6da4b to
d4da2a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually the missing unsigned in the #6264 PR where due to the script ignoring it 🙈
Dav app is fixed in #6562
So this fixes the old migration, which you shouldn't do, but we want to prevent changing the tables twice on huge instances and this was never in a release so far, so should be okay.