[WIP] Move actions of sharing link to popover menu#7010
Closed
jancborchardt wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Member
Member
|
I would say we should better spend our time on #5336 and then this will be automatically be the case. Otherwise there was no activity since over half a year. Let's close it then and we can reopen anytime once this turns out to be the way to go. |
Member
Author
|
@MorrisJobke this is actually intended to be a first step towards implementation of #5336, and it’s still the way to go. I wouldn’t close it hence, but it would be nice if some @nextcloud/javascript folks could have a look at it. :) |
Codecov Report
@@ Coverage Diff @@
## master #7010 +/- ##
============================================
- Coverage 52.76% 52.52% -0.25%
Complexity 22802 22802
============================================
Files 1442 1381 -61
Lines 88563 80950 -7613
Branches 1349 0 -1349
============================================
- Hits 46729 42517 -4212
+ Misses 41834 38433 -3401 |
31 tasks
Member
|
This is now the case: Was fixed by #10218 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Moving the actions (editability, password protection) to the 3-dot-menu which is shown to the right of the share link input.
TODO and where I need help from @nextcloud/javascript @blizzz @MorrisJobke @danxuliu