Fix input field not disabled while a comment is being sent#7266
Merged
MorrisJobke merged 2 commits intoNov 27, 2017
Merged
Conversation
Since the change of the text area to a content editable div the input field was no longer disabled while a new comment was being sent. It was caused by still trying to disable the div using the "disabled" property, which works only on real input fields; when using a content editable div the way to disable it is by setting "contenteditable" to "false". Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
added
2. developing
Codecov Report
@@ Coverage Diff @@
## master #7266 +/- ##
============================================
- Coverage 50.86% 50.86% -0.01%
Complexity 24550 24550
============================================
Files 1585 1585
Lines 93811 93811
Branches 1354 1354
============================================
- Hits 47717 47716 -1
- Misses 46094 46095 +1
|
MorrisJobke
approved these changes
Nov 27, 2017
MorrisJobke
left a comment
MorrisJobke
left a comment
Member
There was a problem hiding this comment.
Tested and works 👍
I would keep the CSS for now. We could refactor later, but it is okay from my side.
Member
See my inline comment 😉 |
MorrisJobke
added
3. to review
Member
|
@jancborchardt @pixelipo @skjnldsv Other opinions? |
MorrisJobke
deleted the
fix-input-field-not-disabled-while-a-comment-is-being-sent
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7240
Pending: @nextcloud/designers CSS masters, please amend and force push again the last commit :-) It is an ugly copy paste, so there are several duplicated and overriden rules ;-)