Fix strpos if needle is not found#7816
Merged
Merged
Conversation
Found while testing strict_typing for PHP 7+. If `$script` does not contain a `/` then it should extract a string of the length 0. Signed-off-by: Morris Jobke <hey@morrisjobke.de>
rullzer
approved these changes
Jan 12, 2018
icewind1991
approved these changes
Jan 12, 2018
nickvergessen
approved these changes
Jan 12, 2018
Codecov Report
@@ Coverage Diff @@
## master #7816 +/- ##
============================================
- Coverage 52.87% 51.23% -1.65%
- Complexity 23658 24971 +1313
============================================
Files 1449 1607 +158
Lines 80454 95008 +14554
Branches 0 1376 +1376
============================================
+ Hits 42541 48673 +6132
- Misses 37913 46335 +8422
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while testing strict_typing for PHP 7+ (#7392). If
$scriptdoes not contain a/then it should extract a string of the length 0.