Add directdownload endpoint#9178
Merged
Merged
Conversation
Member
Author
Member
|
Can I haz hooks for activities 🤓 |
Member
Author
|
@nickvergessen o yes please that would be awesome! |
Member
Author
|
@nickvergessen when do you want the hooks? On creation or on access? (or both?) |
Codecov Report
@@ Coverage Diff @@
## master #9178 +/- ##
============================================
- Coverage 51.92% 51.91% -0.02%
- Complexity 25388 25429 +41
============================================
Files 1608 1618 +10
Lines 95429 95644 +215
Branches 1394 1394
============================================
+ Hits 49555 49656 +101
- Misses 45874 45988 +114
|
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Tests * No directdownload from storage yet (as it is not tested at all) * No direct links for folders Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
393422a to
1c75dda
Compare
Member
Author
|
Ok let do this. I can add the activity hooks later. @tobiasKaminsky already played around with it on android and it seems to do the job ;) |
Member
|
Yes, from my side it is working :-) |
2 tasks
icewind1991
approved these changes
Apr 27, 2018
11 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9142
A basic endpoint to allow clients to have an easy streaming endpoint (for example opening a file in VLC).
<server>/ocs/v2.php/apps/dav/api/v1/directwithfileId=<x>We first ask the storage for a link (S3 for example could provide this directly). Otherwise we generate a 60 char token.
The link thus only gives read access for a limited time.
The link is read only (of course)
The link is more than unique enough (just check 62^60)
Todo: