feat: add phpinfo #469
Merged
feat: add phpinfo #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaIng
approved these changes
Jun 21, 2023
Member
MichaIng
left a comment
MichaIng
left a comment
There was a problem hiding this comment.
Good idea. This makes it easier for admins to check PHP configs, and whether theirs are applied as expected. I am thinking about OPcache, but helpful for other things as well.
Approving only the idea here, as I did not find time to test it yet.
szaimen
approved these changes
Jun 22, 2023
templates/settings-admin.php
Outdated
| <em id="phpExtensions"><?php p($_['php']['extensions'] !== null ? implode(', ', $_['php']['extensions']) : $l->t('Unable to list extensions')); ?></em> | ||
| </p> | ||
| <p> | ||
| <a target="_blank" href="<?= $_['phpinfoUrl'] ?>">phpinfo</a> |
Contributor
There was a problem hiding this comment.
can we make this a button somehow? Currently it is not good to discover imho
Contributor
There was a problem hiding this comment.
Or maybe use the primary color for it?
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
phpinfo-phpinfo-phpinfo
branch
from
3e5c9ee to
a5998e2
Compare
szaimen
reviewed
Jun 22, 2023
|
|
||
| Show phpinfo | ||
|
|
||
| ``php occ config:app:set --value=yes serverinfo phpinfo`` |
Contributor
There was a problem hiding this comment.
why are you making the feature opt-in instead opt-out?
Collaborator
Author
There was a problem hiding this comment.
Joas suggested it.
Contributor
There was a problem hiding this comment.
Maybe make it opt-out instead?
This was referenced Jul 4, 2023
Closed
joshtrichards
added a commit
to joshtrichards/nc-documentation
that referenced
this pull request
Jul 16, 2023
Documents the functionality added in nextcloud/serverinfo#469 Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.