Bump phpSPO to 2.4, brings 2019 support #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
force-pushed
the
enh/noid/bump-phpspo
branch
from
57b601d to
1e292d5
Compare
blizzz
force-pushed
the
enh/noid/bump-phpspo
branch
from
1e292d5 to
47f8933
Compare
blizzz
force-pushed
the
enh/noid/bump-phpspo
branch
from
47f8933 to
3d7abdc
Compare
* adjusts to namespace changes * adjusts to simplified client context and auth mechanism Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
- file content items are provided as Field - fetch lastResponse via event, since Requests::getHistory() was removed - getProperties() was removed, provide a list of known properties - adjust to changed auth mechanism - migrate NTLM auth mechanism Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
enh/noid/bump-phpspo
branch
from
3d7abdc to
b91194c
Compare
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
requested review from
a team,
come-nc,
nickvergessen and
vanpertsch
and removed request for
a team
Member
Author
|
/backport to stable23 |
Member
Author
|
/backport to stable22 |
Member
Author
|
/backport to stable21 |
come-nc
approved these changes
Mar 3, 2022
lib/Client.php
Outdated
| } else { | ||
| $lastRequest = $this->getLastRequestData(); | ||
| if (!isset($lastRequest['response'])) { | ||
| if (!isset($this->lastResponse)) { |
Contributor
There was a problem hiding this comment.
redundant with if (!isset($this->lastResponse['error'])) { on line 132
lib/Client.php
Outdated
| namespace OCA\SharePoint; | ||
|
|
||
| use Exception; | ||
| use OCP\ILogger; |
Contributor
There was a problem hiding this comment.
It seems ILogger was not used before and I don’t see it used in the diff?
Member
Author
There was a problem hiding this comment.
In ensureConnection(), but let me replace that as well.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
This was referenced Apr 8, 2022
Member
Author
|
/backport to stable20 |
|
The backport to stable20 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #49