Do not show room names when the user is not part of it

[nickvergessen]

Follow up to #1426

Views:

• Black - Owner of the files
• White - Owner of the rooms

Shares:

• Shared to room "Playdowns"
• Shared to room without a name set
• Shared in one-to-one conversation between test1 and test2

[nickvergessen]

/backport to stable15

[nickvergessen]

/backport to stable14

[nickvergessen]

Functional tests pass locally, merging

[backportbot-nextcloud]

backport to stable15 in #1497

[backportbot-nextcloud]

The backport to stable14 failed. Please do this backport manually.

[danxuliu]

When the room has no name I would either return the list of participants (which would be consistent with how unnamed rooms are shown in the main Talk UI) or an empty string so clients can decide the best way to show the lack of name.

For example, in the share tab of the Files app, when a file is shared with a user in a room with no name now it shows Shared with you and the conversation Unnamed conversation by user0; before it showed Shared with you in a conversation by user0, which in my opinion is better.

[nickvergessen]

Yeah, but before that, the list of (re-)shares listed it as (conversation) with an empty avatar. Certainly a worse option.

Anyway, I don't think neither is too important and in the future we should prevent empty room names, as they just cause too much weird behaviour

[danxuliu]

Yeah, but before that, the list of (re-)shares listed it as (conversation) with an empty avatar. Certainly a worse option.

I agree, but that was a bug in the Sharing tab, not in Talk itself.

Anyway, I don't think neither is too important and in the future we should prevent empty room names, as they just cause too much weird behaviour

OK.