Fix last local media state not remembered when the UI is reloaded#1548
Merged
nickvergessen merged 2 commits intoFeb 18, 2019
Merged
Conversation
When the local video is enabled or disabled its state is written to the local storage in order to restore it in the next call. However, due to a typo, the previous value was not properly set again when the Talk UI was reloaded. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
When the local audio is enabled or disabled its state is written to the local storage in order to restore it in the next call. However, the previous value was not properly set again when the Talk UI was reloaded; when the MediaControlsView is created the audio is not available yet, so calling "disableAudio()" did nothing. Moreover, as "audioDisabled" was not set to "false" once the audio was available the audio was always enabled in "initAudioVideoSettings". Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Member
Author
|
/backport to stable15 |
nickvergessen
deleted the
fix-last-local-media-state-not-remembered-when-the-ui-is-reloaded
branch
February 18, 2019 16:01
|
backport to stable15 in #1550 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a regression introduced in c4c047a
How to test
Result with this pull request:
Audio and video are still disabled.
Result without this pull request:
Audio and video are enabled.