Make room names non-optional#1567
Merged
Merged
Conversation
nickvergessen
added
2. developing
enhancement
feature: api 🛠️
nickvergessen
commented
Feb 20, 2019
| 'alluserids' => $room->getParticipantUserIds(), | ||
| 'properties' => [ | ||
| 'name' => $room->getName(), | ||
| 'name' => $room->getDisplayName(''), |
Member
Author
There was a problem hiding this comment.
@fancycode what do you use the name for?
Because it will be "UserA, UserB" for one-to-one rooms now, because the same message is used for both participants and I can not send different messages?
nickvergessen
force-pushed
the
feature/noid/non-empty-room-names
branch
3 times, most recently
from
February 21, 2019 15:52
9524545 to
e4c8731
Compare
Member
Author
|
Na, a rebase should be enough, let me do that. |
nickvergessen
force-pushed
the
feature/noid/non-empty-room-names
branch
from
February 26, 2019 09:52
07e6cf0 to
b6bd023
Compare
Member
Author
|
And pushed a fix to add names to all the integration rooms |
11 tasks
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
because mobile apps and web use it to get the avatar Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
feature/noid/non-empty-room-names
branch
from
February 27, 2019 14:27
7f276b1 to
2af378f
Compare
Member
Author
|
Rebased to fix the conflict in UserMentionsTest |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Now there is no longer a "New group conversation" item shown in the conversation list dropdown; instead first the desired conversation name needs to be typed in the search input and then the group conversation with that name is selected in the dropdown. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
force-pushed
the
feature/noid/non-empty-room-names
branch
from
February 27, 2019 17:37
d4f445a to
ddae520
Compare
Although the server will refuse to set an empty room name "validate" was implemented in "Room" model, which prevents "Room.save" from even sending the empty name to the server. The EditableTextLabel now checks too if an "invalid" event was triggered when calling "Model.save", and if that happens it simply hides the input showing again the label without changes; it would be better to keep the input and show the error message instead, but for now it is good enough. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Member
|
I have squashed the fixes for the unit and acceptance tests. Besides that, I added a commit to prevent saving an empty name for a room. |
danxuliu
approved these changes
Feb 27, 2019
danxuliu
left a comment
danxuliu
left a comment
Member
There was a problem hiding this comment.
Tested and works; empty names in existing rooms are nicely converted to the list of users 👍
I think that the UX to create a new group or public room needs further work, but we can do that later.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should work fine with Internal signaling already.