fix: add scheduling meta data

[miaulalala]

☑️ Resolves

Fixes #16777

🛠️ API Checklist

🚧 Tasks

• ...

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not possible
• 📘 API documentation in docs/ has been updated or is not required
• 🔖 Capability is added or not needed

[nickvergessen]

Can we add a test?

[nickvergessen]

/backport to stable33

[nickvergessen]

Should add inline docs when this is the case and on sendAt document when it could be 0

[miaulalala]

Should add inline docs when this is the case and on sendAt document when it could be 0

What does that look like? Add it on the toArray() Method?

[nickvergessen]

spreed/lib/ResponseDefinitions.php

Line 265 in 27e1e62

* // The unique identifier for the given actor type

[miaulalala]

spreed/lib/ResponseDefinitions.php

Line 265 in 27e1e62

* // The unique identifier for the given actor type

Neat, thanks, I wasn't sure what was meant with "Inline docs" 🙈

[Antreesy]

Otherwise works as expected, thanks)

[miaulalala]

Can we add a test?

I added the data to the current test setup, it will run any time sendAt is 0

[nickvergessen]

I added the data to the current test setup, it will run any time sendAt is 0

There was no integration test failing before.

IIRC potential test would be:

1. basic room setup
2. schedule a message
3. revoke chat permission from user in 2
4. run background job
5. as user from 2 check your schedules?

[miaulalala]

I added the data to the current test setup, it will run any time sendAt is 0

There was no integration test failing before.

IIRC potential test would be:

1. basic room setup

2. schedule a message

3. revoke chat permission from user in 2

4. run background job

5. as user from 2 check your schedules?

Literally

spreed/tests/integration/features/chat-4/scheduled-messages.feature

Line 535 in f367b69

Scenario: Schedule a reply, but the account's chat permissions have been revoked in the meantime

[nickvergessen]

Right, then we can add originalSendAt there on this lines?

    Then user "participant2" sees the following scheduled messages in room "room" with 200
      | id        | actorType | actorId      | threadId | parent | message   | messageType | sendAt | silent |
      | Message 1 | users     | participant2 | 0        | null   | Message 1 | comment     | 0      | false

That basically would test your PR

[miaulalala]

Right, then we can add originalSendAt there on this lines?

    Then user "participant2" sees the following scheduled messages in room "room" with 200
      | id        | actorType | actorId      | threadId | parent | message   | messageType | sendAt | silent |
      | Message 1 | users     | participant2 | 0        | null   | Message 1 | comment     | 0      | false

That basically would test your PR

Why, it's already being added in the FeatureContext:

if ($row['sendAt'] !== '0') {
				$row['sendAt'] = self::$messageIdToTimestamp[$row['id']];
			} else {
				$row['originalSendAt'] = self::$messageIdToTimestamp[$row['id']];
			}

[nickvergessen]

Ah, now I see it.
instead of having the time in the test itself, you add the value magically with the FeatureContext

[nickvergessen]

I added a small commit to make the test more clear, let me know what you think

[miaulalala]

I added a small commit to make the test more clear, let me know what you think

Looks good, thanks for that! Shall I squash and rebase?

[nickvergessen]

After you added the docs you can do that yeah