Move remaining views to precompiled Handlebars templates#1706
Merged
nickvergessen merged 8 commits intoApr 11, 2019
Merged
Conversation
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The full Handlebars library was added in Talk when it was removed from the server (during the Nextcloud 16 cycle), as it was still needed in Talk to compile Handlebars templates at runtime. Now that all the Handlebars templates are precompiled the library can be removed. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
This was referenced Apr 10, 2019
Merged
Member
|
Arg, I'd like to not have done this... but now server was merged... |
nickvergessen
approved these changes
Apr 11, 2019
nickvergessen
left a comment
nickvergessen
left a comment
Member
There was a problem hiding this comment.
Did some clicks, did not 💥
nickvergessen
deleted the
move-remaining-views-to-precompiled-handlebars-templates
branch
April 11, 2019 09:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a refactoring; there should be no functional changes.
The full Handlebars library was added in Talk when it was removed from the server (during the Nextcloud 16 cycle), as it was still needed in Talk to compile Handlebars templates at runtime. Now that all the Handlebars templates are precompiled the library can be removed.