Skip to content

fix popover position#192

Merged
MorrisJobke merged 1 commit into
masterfrom
fix-popover
Dec 16, 2016
Merged

fix popover position#192
MorrisJobke merged 1 commit into
masterfrom
fix-popover

Conversation

@jancborchardt

Copy link
Copy Markdown
Member

Before & after:
capture du 2016-12-15 16-21-46 capture du 2016-12-15 16-22-04

Please review @nextcloud/designers

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@tcitworld

Copy link
Copy Markdown
Member

Isn't this somehow related to nextcloud/server#2545 ?

@Ivansss Ivansss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@skjnldsv

Copy link
Copy Markdown
Member

@jancborchardt you shouldn't need to position the popover if you use the guidelines I put in nextcloud/server#2545 :)

@skjnldsv skjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me check! :)

@skjnldsv skjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, this works. But the best will be to add it like I said in the guidelines:

For référence: the popover menu should be inside the div containing the dots icon.
The required right distance to the border (or padding, whatever you want to use) of the three-dot icon should be 14px (5 for menu margin and 6 for arrow position)

@MorrisJobke MorrisJobke merged commit 70c7ea3 into master Dec 16, 2016
@MorrisJobke MorrisJobke deleted the fix-popover branch December 16, 2016 18:08
marcoambrosini pushed a commit that referenced this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants