Skip to content

Video verification#2740

Closed
nickvergessen wants to merge 4 commits into
masterfrom
add-talk-sidebar-to-public-share-auth-page
Closed

Video verification#2740
nickvergessen wants to merge 4 commits into
masterfrom
add-talk-sidebar-to-public-share-auth-page

Conversation

@nickvergessen

@nickvergessen nickvergessen commented Jan 14, 2020

Copy link
Copy Markdown
Member

@nickvergessen nickvergessen added this to the 💚 Next Major (18) milestone Jan 14, 2020
@nickvergessen nickvergessen added 3. to review enhancement feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents regression labels Jan 14, 2020
@nickvergessen nickvergessen changed the title Add talk sidebar to public share auth page Video verification Jan 14, 2020
@nickvergessen

Copy link
Copy Markdown
Member Author

@danxuliu Unable to resolve path to module './services/publicShareAuthService' import/no-unresolved

@nickvergessen

Copy link
Copy Markdown
Member Author

#2738 is merged, please rebase

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@danxuliu
danxuliu force-pushed the add-talk-sidebar-to-public-share-auth-page branch from 0c1207b to 0ffab11 Compare January 14, 2020 15:49
@danxuliu danxuliu closed this Jan 14, 2020
@danxuliu

Copy link
Copy Markdown
Member

Replaced by #2743

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Video verification is missing

2 participants