Print sharing error on correct level#2976
Merged
Merged
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
3. to review
bug
feature: frontend 🖌️
Member
Author
|
Error message is better without the |
Member
Author
|
/backport to stable18 |
marcoambrosini
approved these changes
Feb 19, 2020
marcoambrosini
left a comment
marcoambrosini
left a comment
Member
There was a problem hiding this comment.
Tested and works but shouldn't one be always allowed to reshare the file with the file owner in the chat?
Member
Author
Well arguable, but gets difficult already with group conversation and so on. So for now if you cant share, you have to copy paste an internal link yourself. |
|
backport to stable18 in #2981 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2900