Extend the signaling setting API to allow somewhat clustering by nickvergessen · Pull Request #3292 · nextcloud/spreed

nickvergessen · 2020-04-07T14:30:00Z

Improve "random empty default picking"
Add token when requesting signaling information
Make sure the UI uses the correct signaling server per conversation

nickvergessen · 2020-04-15T15:52:41Z

Should be functional now.

We still pick a random one for the first participant, but that is hard to make right without a real usecase in hand. But adjusting that should be rather easy in the end, so testing it for now should be fine.

Most effects should be noticable without the clustering.
But real clustering is skipped unless there is more then one signaling server defined and the config is set. Can be hacked in Config.php by adding return self::SIGNALING_CLUSTER_CONVERSATION; in getSignalingMode().

By replacing: currentSignalingServer = settings.url with currentSignalingServer = settings.url + 'different' iin src/utils/webrtc/index.js you can also fake a different signalign server being used all the time, making you close and open the connection on every conversation change.

nickvergessen · 2020-04-15T15:53:37Z

Would be nice if you can have a quick look and spill your opinion @danxuliu

nickvergessen · 2020-04-27T13:51:13Z

Added a commit to check the config.php for a hardcoded list to allow overwriting the random for some known big conversations which can then be assigned specifically to always end up on the set machines

So we can use it to decide which HPB to talk to Signed-off-by: Joas Schilling <coding@schilljs.com>

Signed-off-by: Joas Schilling <coding@schilljs.com>

Now a single signaling connection is kept open no matter how many signaling servers are available. When joining a conversation the signaling settings for that conversation are always got, as the signaling server could have changed since the last time it was joined. If the conversation uses a different signaling server than the one currently open that connection is closed and a connection to the new signaling server is started. If a different conversation is joined while waiting for joining to a previous one the previous one is cancelled and only the latest one is taken into account. All the other signaling operations (joining a call, leaving a call or leaving a conversation) are taken into account only if they act on a conversation that belongs to the current signaling server. Otherwise they are ignored. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Signed-off-by: Joas Schilling <coding@schilljs.com>

danxuliu

After the last changes there are no ghost sessions and forced reconnections work. However, during a forced reconnection now the UI goes back to the chat view and then shows again the call view (the same that happened in Talk 7).

Other than that and the unit tests everything seems to work now.

Signed-off-by: Joas Schilling <coding@schilljs.com>

nickvergessen · 2020-05-12T12:44:05Z

Ran unit tests locally, they pass and random integration tests also still worked, so merging

morph027 · 2020-06-06T12:34:00Z

Jumping in here...Running latest version of NC and Talk (19 + 9) and Redis but i can't find a possibilty to add more than one signaling server in talk settings. Do i miss something?

nickvergessen · 2020-06-06T14:05:36Z

The HPB can handle a few hundred users by default without any bigger problems. If you need the clustering you should get in contact with our sales team for a Nextcloud Talk Enterprise Subscription:

https://nextcloud.com/talk#pricing

morph027 · 2020-06-06T14:32:56Z

Ah, well, not really necessary, just stumbled upon this in the release notes and wanted to try to satisfy my curiosity and improve knowledge about everything ;)

nickvergessen added 2. developing enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: signaling 📶 Internal and external signaling backends technical debt feature: frontend 🖌️ "Web UI" client labels Apr 7, 2020

nickvergessen added this to the 💚 Next Major (19) milestone Apr 7, 2020

nickvergessen force-pushed the feature/noid/hpb-clustering-per-conversation branch 3 times, most recently from 18d030a to 2be5e72 Compare April 14, 2020 11:29

nickvergessen force-pushed the feature/noid/hpb-clustering-per-conversation branch from 2be5e72 to 30fee5c Compare April 15, 2020 15:45

nickvergessen marked this pull request as ready for review April 15, 2020 15:46

nickvergessen force-pushed the feature/noid/hpb-clustering-per-conversation branch from 30fee5c to d4d8cca Compare April 15, 2020 15:50

nickvergessen requested a review from danxuliu April 15, 2020 15:52

nickvergessen force-pushed the feature/noid/hpb-clustering-per-conversation branch from d4d8cca to 5a7365e Compare April 16, 2020 07:10

nickvergessen added 3. to review and removed 2. developing labels Apr 23, 2020

nickvergessen requested a review from Ivansss April 27, 2020 06:43

nickvergessen force-pushed the feature/noid/hpb-clustering-per-conversation branch from 5a7365e to 22c44b3 Compare April 27, 2020 06:46

This was referenced Apr 27, 2020

Don't try to reconnect the socket when we closed it intentionally #3402

Merged

Create the initialState in a single location #3403

Merged

danxuliu reviewed Apr 28, 2020

View reviewed changes

Comment thread lib/TInitialState.php Outdated

danxuliu mentioned this pull request Apr 29, 2020

Add wrappers for signaling related functions #3418

Merged

danxuliu force-pushed the feature/noid/hpb-clustering-per-conversation branch 2 times, most recently from f73b07f to 154502c Compare May 5, 2020 18:13

nickvergessen requested a review from danxuliu May 6, 2020 07:39

nickvergessen mentioned this pull request May 6, 2020

As guest or un-invited user, the room load all the messages #3463

Closed

nickvergessen and others added 15 commits May 12, 2020 10:40

Hand in the Room object to the deeper levels

bf5489f

So we can use it to decide which HPB to talk to Signed-off-by: Joas Schilling <coding@schilljs.com>

Require a distributed MemCache

bbcb75c

Signed-off-by: Joas Schilling <coding@schilljs.com>

Introduce a manager to get the signaling server

21e22af

Signed-off-by: Joas Schilling <coding@schilljs.com>

Send the backend message to the correct backend server for now

eda9d44

Signed-off-by: Joas Schilling <coding@schilljs.com>

Reset the assigned signaling server after some time

650427e

Signed-off-by: Joas Schilling <coding@schilljs.com>

Allow to hardcode a signaling server per conversation token

3fe01a1

Signed-off-by: Joas Schilling <coding@schilljs.com>

Add a signaling_dev app config for easier HPB clustering development

15b71fb

Signed-off-by: Joas Schilling <coding@schilljs.com>

Add license and remove auto-generate comment from migration

ae0bf7f

Signed-off-by: Joas Schilling <coding@schilljs.com>

Move to API v2

78b221f

Signed-off-by: Joas Schilling <coding@schilljs.com>

Use the constants everywhere

71f164a

Signed-off-by: Joas Schilling <coding@schilljs.com>

Also check the sessionId when delaying the joinRoom

af927db

Signed-off-by: Joas Schilling <coding@schilljs.com>

Also free up the webrtc when changing HPB

9570c3a

Signed-off-by: Joas Schilling <coding@schilljs.com>

Don't throw an exception in case of entropy fail

a7bcad3

Signed-off-by: Joas Schilling <coding@schilljs.com>

Refresh the session before closing the connection

40fa7c6

Signed-off-by: Joas Schilling <coding@schilljs.com>

nickvergessen force-pushed the feature/noid/hpb-clustering-per-conversation branch from 8c9e598 to 40fa7c6 Compare May 12, 2020 08:41

danxuliu reviewed May 12, 2020

View reviewed changes

Fix unit tests

7629494

Signed-off-by: Joas Schilling <coding@schilljs.com>

danxuliu approved these changes May 12, 2020

View reviewed changes

nickvergessen merged commit c58a9f2 into master May 12, 2020

nickvergessen deleted the feature/noid/hpb-clustering-per-conversation branch May 12, 2020 12:44

This was referenced May 13, 2020

Signaling per conversation #2560

Closed

Leave a call, but you can still hear and talk (not see) #3549

Closed

danxuliu mentioned this pull request May 14, 2020

[stable18] Take config settings into account when promoting an update #3554

Merged

This was referenced May 25, 2020

Support for High-performance backend clustering nextcloud/talk-android#851

Closed

Support for High-performance backend clustering nextcloud/talk-ios#317

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Extend the signaling setting API to allow somewhat clustering#3292

Extend the signaling setting API to allow somewhat clustering#3292
nickvergessen merged 24 commits into
masterfrom
feature/noid/hpb-clustering-per-conversation

nickvergessen commented Apr 7, 2020 •

edited

Loading

Uh oh!

nickvergessen commented Apr 15, 2020

Uh oh!

nickvergessen commented Apr 15, 2020

Uh oh!

nickvergessen commented Apr 27, 2020

Uh oh!

Uh oh!

danxuliu left a comment

Uh oh!

nickvergessen commented May 12, 2020

Uh oh!

morph027 commented Jun 6, 2020

Uh oh!

nickvergessen commented Jun 6, 2020

Uh oh!

morph027 commented Jun 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

nickvergessen commented Apr 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nickvergessen commented Apr 15, 2020

Uh oh!

nickvergessen commented Apr 15, 2020

Uh oh!

nickvergessen commented Apr 27, 2020

Uh oh!

Uh oh!

danxuliu left a comment

Choose a reason for hiding this comment

Uh oh!

nickvergessen commented May 12, 2020

Uh oh!

morph027 commented Jun 6, 2020

Uh oh!

nickvergessen commented Jun 6, 2020

Uh oh!

morph027 commented Jun 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nickvergessen commented Apr 7, 2020 •

edited

Loading