Fix split "being in a room" from "calling"#467
Merged
Conversation
Member
|
First commit is now in #471 |
Merged
Member
|
I will take this over |
Since commit eae71a3 a participant (user or guest) can be in a room without joining a call; since then sessions are no longer set and passwords are no longer checked when joining a call, but when joining a room. Due to this some integration tests had to be modified to join a room instead of a call. Note, however, that in the modified tests there is no need to join a call too once the participant has joined the room, as they either test joining the room itself (the password tests) or the tested actions simply need the participant to be in a room (the chat tests). Moreover, in this later case, note that a participant is in a room if she created a room, was invited to it or explicitly joined it, so the chat tests involving a participant creating a room or inviting another one to it did not need to be modified. Finally, neither the call tests nor the "userJoinsCall" method from FeatureContext were modified yet, as it has to be decided first whether directly joining a call also joins the room automatically or not. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
nickvergessen
force-pushed
the
fix-split-being-in-a-room-from-calling
branch
from
ebc2568 to
41ab1d7
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Member
|
Fixed, also guest handling is fixed now and they can join and leave as they want. Sometimes it takes a while until the first connection works, but afterwards it's always instant. |
nickvergessen
approved these changes
Nov 10, 2017
nickvergessen
left a comment
nickvergessen
left a comment
Member
There was a problem hiding this comment.
Approving the part of Daniel
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up for #459.
This pull request fixes the arguments passed to
Participantconstructor (which fixes joining a room as a guest from the UI) and the integration tests for setting a password and chatting, as they should join a room instead of a call since the changes introduced in the previous pull request.The integration tests are not fully fixed yet, though. It seems that it is no longer possible to join a call without joining the room first, not even for the creator or someone who was invited to the room. The question is, should directly joining a call automatically make the participant to join the room too? Or should it be kept like now, in which the participant must join the room explicitly? @Ivansss @nickvergessen Please fix the code and/or the integration tests as needed.
Fix #465