Add button to expand tabs in the sidebar#558
Closed
danxuliu wants to merge 2 commits into
Closed
Conversation
The ElementExpanderButton is a helper class to expand (and restore) an element in an ancestor. It works directly on HTML elements and it does not take into account Backbone or Marionette views; it simply traverses the ancestors of the expandable element hiding their siblings until the container is reached. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Due to the scroll bar being shown only for the tabs the call details are always visible. In short screens this may not leave too much space for the tabs, making them uncomfortable to use. To improve that now an ElementExpanderButton is added automatically to every tab added to the sidebar; clicking on the button toggles the associated tab between its normal size and an expanded size that fills the whole sidebar. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
This was referenced Jan 10, 2018
Member
|
Hum, this is adding a confusing mode which needs another action/icon on top. Rather than that, it seems like here we should:
|
This was referenced Jan 10, 2018
Member
|
Aaaand see:
|
jancborchardt
requested changes
Jan 10, 2018
jancborchardt
left a comment
jancborchardt
left a comment
Member
There was a problem hiding this comment.
See comment #558 (comment)
This is too much UX-wise, and we should rather clean up the header as per #562
nickvergessen
modified the milestones:
3.0 (Nextcloud 13.0.0),
3.1 (Nextcloud 13.0.2/3)
Member
|
|
Member
Author
|
@nickvergessen I know that it is going to sound surprising... but that is by design. If the icon is in a lower position it would seem to be part of the Add participant field. If it is in a higher position it could overlap with the tab header. The idea was to float it there so it is seen as a separate element... but if you think that it is a bug it seems that the idea failed miserably :-P |
Member
Author
|
Closing. See #493 (comment) |
marcoambrosini
pushed a commit
that referenced
this pull request
Oct 9, 2019
Remove unused isFocusable computed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the scroll bar being shown only for the tabs the call details are always visible. In short screens this may not leave too much space for the tabs, making them uncomfortable to use.
To improve that now a button is added automatically to every tab added to the sidebar; clicking on the button toggles the associated tab between its normal size and an expanded size that fills the whole sidebar.
I have tried other approaches, like hiding the call details when scrolling in one direction and showing it back when scrolling on the opposite direction, but in the end the button one was the simplest, most reliable and less bug/quirk prone.