Skip to content

Improve password protection UX and UI.#607

Merged
Ivansss merged 4 commits into
masterfrom
improve-password-protection-ui
Feb 12, 2018
Merged

Improve password protection UX and UI.#607
Ivansss merged 4 commits into
masterfrom
improve-password-protection-ui

Conversation

@Ivansss

@Ivansss Ivansss commented Jan 22, 2018

Copy link
Copy Markdown
Member

Password input caught to much attention in the right side bar.

screen shot 2018-01-22 at 17 07 00

It will be hidden by default and a password button will replace it.

screen shot 2018-01-22 at 16 58 35

@jancborchardt It would be nice to have an 'opened lock' icon so we can show it when the room has no password set.

Also, we could have a new combined icon (public + password) for the left side bar, so a user could see directly which public calls are password protected without being in that room.

Something like this:
screen shot 2018-01-22 at 16 58 52

Comment thread js/views/callinfoview.js Outdated
});

this.ui.passwordOption.hide();
this.ui.passwordButton.show();

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to move this into the success function.

Also, if there is an error in the ajax call it should be handled by letting the user know somehow (but without hiding the input field).

@danxuliu

danxuliu commented Jan 22, 2018

Copy link
Copy Markdown
Member

It would be nice to have an 'opened lock' icon so we can show it when the room has no password set.

👍

Also, we could have a new combined icon (public + password) for the left side bar, so a user could see directly which public calls are password protected without being in that room.

👍

@jancborchardt

Copy link
Copy Markdown
Member

It would be nice to have an 'opened lock' icon so we can show it when the room has no password set.

We should do that via opacity as it’s much more clear. When no password is set, the icon should be opacity: .5.

Also, we could have a new combined icon (public + password) for the left side bar, so a user could see directly which public calls are password protected without being in that room.

If we do that then we should have that on any call though, also group calls. So we should have a separate element to overlay the password icon there.

@jancborchardt

Copy link
Copy Markdown
Member

And @Ivansss @danxuliu could we have the input in a popover as discussed? Then we can also move forward with #562 as then it will always be one row for all the call controls.

@Ivansss

Ivansss commented Jan 23, 2018

Copy link
Copy Markdown
Member Author

If we do that then we should have that on any call though, also group calls. So we should have a separate element to overlay the password icon there.

Password protection is only available in public calls.

@nickvergessen

Copy link
Copy Markdown
Member

Please also send a PR against master 🙊 (or better rebase this one)

Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@Ivansss Ivansss force-pushed the improve-password-protection-ui branch from 123b442 to a8de18e Compare January 26, 2018 14:16
@Ivansss Ivansss changed the base branch from stable13 to master January 26, 2018 14:17
@Ivansss

Ivansss commented Jan 26, 2018

Copy link
Copy Markdown
Member Author

Rebased and changed base branch.

Signed-off-by: Ivan Sein <ivan@nextcloud.com>
…uccess.

Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@Ivansss

Ivansss commented Feb 5, 2018

Copy link
Copy Markdown
Member Author

@jancborchardt The password input field is shown in a popover menu now.
But it needs some design love, cause it's not properly aligned.
Also, I'm not sure about the borders of the input field. Maybe we should remove them?

@Ivansss Ivansss force-pushed the improve-password-protection-ui branch from 0aac052 to 4c5af57 Compare February 12, 2018 11:27
@Ivansss Ivansss merged commit efaf8c6 into master Feb 12, 2018
@Ivansss Ivansss deleted the improve-password-protection-ui branch February 12, 2018 11:30
@nickvergessen nickvergessen added this to the 4.0 (Nextcloud 14) milestone Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants