Rich Workspaces - Wrong Readme.md shown when opening Favorites folder

[goligo]

Displaying of the Readme.md on top of folder content is not working properly, when a folder is opened from the favorite list. While the folder content is updated, the Readme.md of the last openend folder is wrongly shown instead. This is highly confusing.

I discovered this on my installation of version 19, it does also reproduce on the public version 20:

• Open instant trial on https://try.nextcloud.com/
• Open "Files"
• Add "Photos" to favorites
• Open "Documents"
• Open "Photos" from the favorites list on the left

You can now see the content of the Photos folder, but the Readme.md content of the Documents folder on top.

[goligo]

Just noticed it is not restricted to the Favorites folders, but also happens when clicking "All files".

[kesselb]

cc @juliushaertl

[goligo]

In

https://github.com/nextcloud/text/blob/master/src/helpers/files.js#L163

the "changeDirectory" event of the filelist is attached to update the RichWorkspace display, whenever the directory changes. However in

https://github.com/nextcloud/server/blob/master/apps/files/js/filelist.js#L766

when the URL is changed by someone else (the navigation bar), the changeDirectory method is called with second parameter "changeUrl" false, which is later in

https://github.com/nextcloud/server/blob/master/apps/files/js/filelist.js#L1976

preventing the "changeDirectory" event of the filelist being fired, so the RichWorkspace text is not updated. There has been no change on the relevant filelist code in the last five years, so the event never was fired, when the URL was changed externally.

To fix it either the RichWorkspace must also register to the "urlChanged" event of the filelist to update, or the filelist must always fire "changeDirectory", regardless of whether it was changed by the filelist itself or by the change of the URL.