Ctrl+S doesn't work

[provokateurin]

Describe the bug
Pressing Ctrl+S should save the document, but the browser save dialog opens instead.
#300

To Reproduce
Steps to reproduce the behavior:

1. Press Ctrl+S

Expected behavior
Pressing Ctrl+S should save the document, but the browser save dialog opens instead.

Client details:

• OS: Linux
• Browser: Firefox
• Version: 113
• Device: Desktop

Server details

Text app version: 3.7.2

Operating system: Alpine Linux

Web server: Nginx

Database: Postgres

PHP version: 8.2

Nextcloud version: 26.0.2

[blizzz]

The save is actually triggered, but the browser's save behaviour is triggered just as well.

[luka-nextcloud]

After investigation, it seems like there is no way to prevent the browser's save action since the Ctrl+S is browser's hotkey.

[provokateurin]

But as far as I understood it once used to work?

[mejo-]

Also, in Collabora Online it somehow works. There, Ctrl-S only saves the file and doesn't open the browsers "Save file as" dialog.

[juliusknorr]

For me this only happens when not having the cursor focus in the actual contenteditable element.

@provokateurin Can you tell if this only happens if the editor doesn't have a cursor focus in the document itself?

[juliusknorr]

Note for later:

• Maybe we need to also listen for ctrl+s in the editor wrapper component itself not just in tiptap:
  • https://github.com/nextcloud/text/blob/main/src/components/Editor.vue#L27C9-L27C9
  • https://github.com/nextcloud/text/blob/main/src/components/Editor.vue#L504-L508