Visibility of images, placeholder, permissions (images don’t show for others)

[jancborchardt]

I inserted a picture from the Nextcloud and it shows fine if I open the share link in a new tab of the same window where I’m authenticated in:

In a private window though it doesn’t show:

[juliusknorr]

Yes, this is because the preview is only available if the accessing user has access to the file. We need to carefully think how we should handle this.

My initial idea was to show a placeholder for images that cannot be accessed with a link to the file and mentioning the owner.

[jancborchardt]

Can’t we generate a larger preview which then is accessible? Or do you mean that by placeholder?

[juliusknorr]

No, we cannot generate preview for files the user/guest doesn't have access to, as this would lead to a pretty bad data leak.

We could for sure try to have a separate preview endpoint for files included in the documents, but that really needs to be handled with care, so only the user who has access to the file is allowed to add it.

[jancborchardt]

Ok, then for now we could indeed just show an emptycontent-container with .icon-image and a line below like "Images are not supported in share views yet". Sounds good?

[juliusknorr]

Yes, sounds like a good solution for the first release. We can always improve on that later.

[juliusknorr]

The placeholder is implemented and has a link to open the image. For further improvments let's move this to 2.0