Skip to content

WIP: split into src and package #2278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
max-nextcloud wants to merge 20 commits into from
Closed

WIP: split into src and package #2278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
7f8cfa4
WIP: split into src and package
max-nextcloud Apr 5, 2022
74e80da
build: add alias to babel config
max-nextcloud Apr 5, 2022
505ab88
fix: use webpack resolver and turn off node/no-missing-imports
max-nextcloud Apr 6, 2022
3f3f699
fix: add jsdoc comments as requested by eslint
max-nextcloud Apr 6, 2022
df95e85
run lint and stylelint on package aswell.
max-nextcloud Apr 6, 2022
7048fe6
move ViewerComponent into src
max-nextcloud Apr 6, 2022
1fe5160
refactor: move PublicFilesEditor into src
max-nextcloud Apr 6, 2022
6eeecef
refactor: remove index from package for now.
max-nextcloud Apr 7, 2022
78d4dc2
refactor: RichText extension groups all text formatting
max-nextcloud Apr 7, 2022
4543246
package: for reuse in collectives for now
max-nextcloud Apr 7, 2022
a0ddd8c
refactor: use Editor.new directly in ReadOnlyEditor
max-nextcloud Apr 11, 2022
0465e46
feature: emit clickLink from `ReadOnlyEditor`
max-nextcloud Apr 11, 2022
fc31532
package: make package public
max-nextcloud Apr 13, 2022
7eec8f0
package: mark version as beta
max-nextcloud Apr 13, 2022
ab06e42
fix: exclude screenshots from the package
max-nextcloud Apr 13, 2022
96db954
fix: find link href based on prosemirror node
max-nextcloud Apr 14, 2022
7036c0b
fix: image display with fallback to preview url
max-nextcloud Apr 21, 2022
a1bc784
fix: provide the current directory to ReadOnlyEditor
max-nextcloud Apr 21, 2022
90c605f
fix: image rendering via public previews
max-nextcloud Apr 21, 2022
5bcdfd4
Package Version 0.1.0-beta.5
max-nextcloud Apr 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,18 @@ module.exports = {
extends: [
'@nextcloud',
],
settings: {
'import/resolver': {
webpack: { config: './webpack.js' },
},
},
rules: {
/* Turn off node checks for import resolution.
* Let eslint-plugin-import handle this.
* It knows how to use resolvers.
*
* See https://github.com/mysticatea/eslint-plugin-node/issues/249#issuecomment-747980937
*/
'node/no-missing-import': 'off',
},
}
10 changes: 10 additions & 0 deletions babel.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
const babelConfig = require('@nextcloud/babel-config')

const resolvePlugin = ["module-resolver", {
"alias": {
"@nextcloud/text-editor": "./package",
}
}]

babelConfig.presets[0][1].modules = 'auto'
babelConfig.plugins = [
...babelConfig.plugins,
resolvePlugin,
]

module.exports = babelConfig
12 changes: 6 additions & 6 deletions cypress/integration/ListItem.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import OrderedList from '@tiptap/extension-ordered-list'
import ListItem from '@tiptap/extension-list-item'
import TaskList from './../../src/nodes/TaskList'
import TaskItem from './../../src/nodes/TaskItem'
import BulletList from './../../src/nodes/BulletList'
import Markdown from './../../src/extensions/Markdown'
import markdownit from './../../src/markdownit'
import { createMarkdownSerializer } from './../../src/extensions/Markdown';
import TaskList from '@nextcloud/text-editor/nodes/TaskList'
import TaskItem from '@nextcloud/text-editor/nodes/TaskItem'
import BulletList from '@nextcloud/text-editor/nodes/BulletList'
import Markdown from '@nextcloud/text-editor/extensions/Markdown'
import markdownit from '@nextcloud/text-editor/markdownit'
import { createMarkdownSerializer } from '@nextcloud/text-editor/extensions/Markdown';
import { findChildren, findChildrenByType } from 'prosemirror-utils'
import createEditor from './../../src/tests/createEditor'
import testData from '../fixtures/ListItem.md'
Expand Down
16 changes: 8 additions & 8 deletions cypress/integration/Table.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import Table from './../../src/nodes/Table'
import TableCell from './../../src/nodes/TableCell'
import TableHeader from './../../src/nodes/TableHeader'
import TableRow from './../../src/nodes/TableRow'
import TableHeadRow from './../../src/nodes/TableHeadRow'
import Markdown from './../../src/extensions/Markdown'
import markdownit from './../../src/markdownit'
import { createMarkdownSerializer } from './../../src/extensions/Markdown';
import Table from '@nextcloud/text-editor/nodes/Table'
import TableCell from '@nextcloud/text-editor/nodes/TableCell'
import TableHeader from '@nextcloud/text-editor/nodes/TableHeader'
import TableRow from '@nextcloud/text-editor/nodes/TableRow'
import TableHeadRow from '@nextcloud/text-editor/nodes/TableHeadRow'
import Markdown from '@nextcloud/text-editor/extensions/Markdown'
import markdownit from '@nextcloud/text-editor/markdownit'
import { createMarkdownSerializer } from '@nextcloud/text-editor/extensions/Markdown';
import { findChildren, findChildrenByType } from 'prosemirror-utils'
import createEditor from './../../src/tests/createEditor'
import testData from '../fixtures/Table.md'
Expand Down
Loading