Preserve bullet list style and change default style to -#3523
Merged
Conversation
Contributor
Author
|
/compile |
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
susnux
force-pushed
the
fix/list-style
branch
from
d164483 to
5ec082f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
max-nextcloud
approved these changes
Dec 7, 2022
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
All looks good.
I might as well rebase and fix the remaining test so we can get this in. Hope you don't mind.
Comment on lines
+8
to
+12
| /* | ||
| * This file is for various markdown tests, mainly testing if input and output stays the same. | ||
| * | ||
| * Please add test belonging to some Node or Mark to the corresponding file in './nodes/` or `./marks/` | ||
| */ |
Collaborator
There was a problem hiding this comment.
👍
Thanks for the separation. Makes lot's of sense.
1. Preserve the bullet style used for lists (also task lists) 2. Set default style to `-` Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
max-nextcloud
force-pushed
the
fix/list-style
branch
from
5ec082f to
3b0f92c
Compare
Collaborator
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
First this generally make text preserve the bullet style used for lists (and also task lists).
And also sets the default list style to
-as discussed in the comments of #1297 .Added also test cases (and slightly refactored the test code to remove duplicated code (helpers)).
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)