Skip to content

[stable34] fix(editor): preserve leading newlines in plain text editor #8788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mejo- merged 1 commit into from
Jun 29, 2026
Merged

[stable34] fix(editor): preserve leading newlines in plain text editor #8788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/composables/useEditorMethods.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export const useEditorMethods = (editor: Editor) => {
editor.extensionManager.extensions.includes(Markdown)
const html = hasMarkdownContent
? markdownit.render(content) + '<p/>'
: `<pre>${escapeHtml(content)}</pre>`
: `<pre>\n${escapeHtml(content)}</pre>`
editor
.chain()
.setContent(html, { emitUpdate: addToHistory })
Expand Down
2 changes: 1 addition & 1 deletion src/helpers/setInitialYjsState.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const setInitialYjsState = (
) => {
const html = isRichEditor
? markdownit.render(content) + '<p/>'
: `<pre>${escapeHtml(content)}</pre>`
: `<pre>\n${escapeHtml(content)}</pre>`

const editor = isRichEditor ? createRichEditor() : createPlainEditor()
editor.commands.setContent(html)
Expand Down
2 changes: 1 addition & 1 deletion src/helpers/updateFromContent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const setContent = (
) => {
const html = isRichEditor
? markdownit.render(content) + '<p/>'
: `<pre>${escapeHtml(content)}</pre>`
: `<pre>\n${escapeHtml(content)}</pre>`
const editor = isRichEditor
? createRichEditor({
extensions: [Collaboration.configure({ document: doc })],
Expand Down
9 changes: 1 addition & 8 deletions src/tests/plaintext.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const escapeHTML = (s) => {
}

const plaintextThroughEditor = (markdown) => {
const content = '<pre>' + escapeHTML(markdown) + '</pre>'
const content = '<pre>\n' + escapeHTML(markdown) + '</pre>'
const tiptap = createPlainEditor()
tiptap.commands.setContent(content)
const plaintext = serializePlainText(tiptap.state.doc) || 'failed'
Expand All @@ -27,14 +27,7 @@ const plaintextThroughEditor = (markdown) => {
}

describe('commonmark as plaintext', () => {
// FIXME: Those two tests currently fail as trailing whitespace seems to be stripped,
// if it occurs in the first line which is empty otherwise.
const skippedMarkdownTests = [97, 117]

spec.forEach((entry) => {
if (skippedMarkdownTests.indexOf(entry.example) !== -1) {
return
}
test('commonmark ' + entry.example, () => {
expect(plaintextThroughEditor(entry.markdown)).toBe(entry.markdown)
})
Expand Down
Loading