Skip to content

fix(ImageView): use a element for clickable items#8813

Merged
mejo- merged 1 commit into
mainfrom
fix/attachments_cursor
Jul 9, 2026
Merged

fix(ImageView): use a element for clickable items#8813
mejo- merged 1 commit into
mainfrom
fix/attachments_cursor

Conversation

@mejo-

@mejo- mejo- commented Jul 4, 2026

Copy link
Copy Markdown
Member

Fixes the cursor not being a pointer on a clickable item.

Also move the click handler for non-image attachments from the full-width container box to the attachment box with a visible boundary.

Fixes: #8801

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

🤖 AI (if applicable)

  • The content of this PR was partly generated using AI tools
  • The AI-generated content was reviewed, comprehended and tested by a human

@mejo- mejo- self-assigned this Jul 4, 2026
@mejo- mejo- added bug Something isn't working 3. to review labels Jul 4, 2026
@github-project-automation github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team Jul 4, 2026
@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity team Jul 4, 2026
@mejo-

mejo- commented Jul 4, 2026

Copy link
Copy Markdown
Member Author

/backport to stable34

@mejo-

mejo- commented Jul 4, 2026

Copy link
Copy Markdown
Member Author

/backport to stable33

@mejo-

mejo- commented Jul 4, 2026

Copy link
Copy Markdown
Member Author

/backport to stable32

@mejo- mejo- force-pushed the fix/attachments_cursor branch from 07f3bfe to f8096ec Compare July 4, 2026 20:55
Comment thread src/nodes/ImageView.vue Outdated
Comment thread src/nodes/ImageView.vue Outdated
Fixes the cursor not being a pointer on a clickable item.

Also move the click handler for non-image attachments from the
full-width container box to the attachment box with a visible boundary.

Fixes: #8801

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the fix/attachments_cursor branch from f8096ec to 4f4afb6 Compare July 9, 2026 01:03
@mejo- mejo- requested a review from max-nextcloud July 9, 2026 01:04
@mejo- mejo- changed the title fix(ImageView): use cursor: pointer for clickable items fix(ImageView): use a element for clickable items Jul 9, 2026

@max-nextcloud max-nextcloud left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Did not test though.

@mejo- mejo- merged commit 331f804 into main Jul 9, 2026
73 of 76 checks passed
@mejo- mejo- deleted the fix/attachments_cursor branch July 9, 2026 08:12
@github-project-automation github-project-automation Bot moved this from 👀 In review to ☑️ Done in 📝 Productivity team Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Hovering attachments doesn't change cursor to pointer

2 participants