[stable33] fix: verify integrity with URL override but allow to disable if needed#724
Merged
Conversation
susnux
force-pushed
the
backport/723/stable33
branch
from
a619cd5 to
ac52a29
Compare
susnux
force-pushed
the
backport/723/stable33
branch
from
ac52a29 to
f4afab9
Compare
Contributor
|
I guess it fails because of #727 |
Altahrim
force-pushed
the
backport/723/stable33
branch
3 times, most recently
from
9b1a3bd to
468d68a
Compare
Altahrim
approved these changes
Mar 31, 2026
Altahrim
force-pushed
the
backport/723/stable33
branch
from
468d68a to
b988bcc
Compare
Before: As soon as an URL override was used no integrity verification was done. Now: Always do integrity verification (to allow custom mirrors or our signed files!). But to also allow third party files where we cannot verify the integrity we allow passing `--no-verify` commandline flag. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Altahrim
force-pushed
the
backport/723/stable33
branch
from
b988bcc to
12bd187
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #723