Skip to content

Play Video Full Screen fails - regression? #819

@VeederLicht

Description

@VeederLicht

Steps to reproduce

  1. Use v21
  2. Play a video
  3. Use the players 'full screen' icon to maximize to full screen

Expected behaviour

Play the video, resized to full screen

Actual behaviour

When enlarging a video during playback using the double arrows in the player, the browser display does maximize to full screen, but the video itself keeps playing in its smaller resolution. I happen to have 2 nextcloud instances running. One on version 20 and one on version 21. The older version does not have this behaviour! Regression?

See attached images:

nextcloud_v20
nextcloud_v21

Server configuration

Operating system:
Arch

Web server:
NGINX

Database:
MariaDB
PHP version:

Nextcloud version: (see Nextcloud admin page)
21.0.0
(correct working version 20.0.4)

Updated from an older Nextcloud/ownCloud or fresh install:
No, fresh install

Where did you install Nextcloud from:
Pacman, arch repo

My own analysis

The difference between the two versions using the browser developertools show that in the correctly working version javascript dynamically updates the style of:
#viewer > div.modal-wrapper.modal-wrapper--large.modal-wrapper--spread-navigation > div > div > div.viewer__file.viewer__file--active

in the newer, faulty version, the javascript instead updates the style of the video element under:
#viewer > div.modal-wrapper.modal-wrapper--large.modal-wrapper--spread-navigation > div > div > div.viewer__file.viewer__file--active > div > div.plyr__video-wrapper

In both cases the height and width of the specified elements are set. If you remove these tags using the developertools, the video behaves as expected and will play fullscreen.

Metadata

Metadata

Assignees

No one assigned

    Labels

    4. to releaseReady to be released and/or waiting for tests to finishbugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions