Closed
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Contributor
|
Thank you for the PR. It's clear from the context how macros should be used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is this resolving a feature or a bug?
This resolves a documentation bug: incorrect Rust attribute syntax in
runtime/README.md. Attributes were written without the#prefix, which is invalid Rust and would not compile if copied.Are there existing issue(s) that this PR would close?
No existing issue.
If this PR is not minimal (it could be split into multiple PRs), please explain why the issues are best resolved together.
The change is minimal and focused: all affected attribute examples in the
runtime/README.mdare fixed in one commit. Splitting would not provide any additional clarity.Describe your changes.
Replaced incorrect attribute syntax in the README:
[nexus_rt::private_input(x)]>#[nexus_rt::private_input(x)][nexus_rt::custom_input]>#[nexus_rt::custom_input][nexus_rt::custom_output]>#[nexus_rt::custom_output]This ensures that documentation examples match valid Rust syntax and prevents compilation errors when copied.