Skip to content

ng-packagr not working with ngrx project #754

@rupeshtiwari

Description

@rupeshtiwari

sample app ngrx-with-ng-packgr.zip

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ x] Bug report  
[ ] Feature request
[ ] Documentation issue or request

What is the current behavior?

ng-packagr is not working


PS Z:\rupesh\rnd\angular\ngrx-with-ng-packgr\my-app> ng-packagr
Building Angular library
Generating bundle for my-app
Cleaning bundle build directory
Processing assets
Running ngc

BUILD ERROR
Error at Z:/rupesh/rnd/angular/ngrx-with-ng-packgr/my-app/.ng_pkg_build/my-app/ts/src/app/app.component.ts:34:14: Exported variable 'getProductState' has or is using name 'MemoizedSelector' from external module "Z:/rupesh/rnd/angular/ngrx-with-ng-packgr/my-app/node_modules/@ngrx/store/src/selector" but cannot be named.
Error: Error at Z:/rupesh/rnd/angular/ngrx-with-ng-packgr/my-app/.ng_pkg_build/my-app/ts/src/app/app.component.ts:34:14: Exported variable 'getProductState' has or is using name 'MemoizedSelector' from external module "Z:/rupesh/rnd/angular/ngrx-with-ng-packgr/my-app/node_modules/@ngrx/store/src/selector" but cannot
be named.
    at new UserError (C:\Users\rtiwari\AppData\Roaming\npm\node_modules\ng-packagr\node_modules\@angular\tsc-wrapped\src\tsc.js:27:28)
    at check (C:\Users\rtiwari\AppData\Roaming\npm\node_modules\ng-packagr\node_modules\@angular\tsc-wrapped\src\tsc.js:93:15)
    at Tsc.typeCheck (C:\Users\rtiwari\AppData\Roaming\npm\node_modules\ng-packagr\node_modules\@angular\tsc-wrapped\src\tsc.js:173:9)
    at C:\Users\rtiwari\AppData\Roaming\npm\node_modules\ng-packagr\node_modules\@angular\tsc-wrapped\src\main.js:122:23
    at <anonymous>

Expected behavior:

ng-packagr should create package successfully like it does for angular project without ngrx.

Minimal reproduction of the problem with instructions:

Please download the ngrx-with-ng-packgr.zip
zip project and then run

npm install
ng-packagr

Version of affected browser(s),operating system(s), npm, node and ngrx:

Browser: Chrome, OS : Windows 2010 , npm 5.6.0, node v8.9.4, ngrx 5.0.1, typescript: ~2.5.3

Other information:

As per microsoft/TypeScript#9944, I also upgraded my typescript version to typescript@next still i am getting the issue.
Please let me know where I am missing something. Also is their any other option to create a package for ngrx project which I can use as npm module. I also created one more issue in ng-packagr not sure where this bug is ng-packagr/ng-packagr#542 It seems that even though we are exporting the MemoizedSelector it is not working properly #57

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions