Skip to content

fix(StoreDevTools): out of bounds when actions are filtered#1532

Merged
brandonroberts merged 3 commits intomasterfrom
pr/devtools-ignore-actions
Jan 28, 2019
Merged

fix(StoreDevTools): out of bounds when actions are filtered#1532
brandonroberts merged 3 commits intomasterfrom
pr/devtools-ignore-actions

Conversation

@timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #1522

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

The same error in the issue occured while using the blacklist or whitelist option.

@coveralls
Copy link

coveralls commented Jan 26, 2019

Coverage Status

Coverage increased (+0.5%) to 89.281% when pulling 3d3f6f0 on pr/devtools-ignore-actions into 48a2370 on master.

@ngrxbot
Copy link
Collaborator

ngrxbot commented Jan 26, 2019

Preview docs changes for 5fef5be at https://previews.ngrx.io/pr1532-5fef5be/

@timdeschryver timdeschryver force-pushed the pr/devtools-ignore-actions branch from 5fef5be to 3d3f6f0 Compare January 27, 2019 13:40
@ngrxbot
Copy link
Collaborator

ngrxbot commented Jan 27, 2019

Preview docs changes for 3d3f6f0 at https://previews.ngrx.io/pr1532-3d3f6f0/

@brandonroberts brandonroberts merged commit d532979 into master Jan 28, 2019
@timdeschryver timdeschryver deleted the pr/devtools-ignore-actions branch March 27, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StoreDevToolsModule predicate throws 'state' undefined error

4 participants