fix(schematics): type actions and avoid endless loop in effect#1576
Merged
brandonroberts merged 1 commit intongrx:masterfrom Feb 26, 2019
fmalcher:fix-schematics-effectloop
Merged
fix(schematics): type actions and avoid endless loop in effect#1576brandonroberts merged 1 commit intongrx:masterfrom fmalcher:fix-schematics-effectloop
brandonroberts merged 1 commit intongrx:masterfrom
fmalcher:fix-schematics-effectloop
Conversation
Collaborator
|
Preview docs changes for 1afec52 at https://previews.ngrx.io/pr1576-1afec52/ |
1 similar comment
Collaborator
|
Preview docs changes for 1afec52 at https://previews.ngrx.io/pr1576-1afec52/ |
modules/schematics/src/effect/files/__name@dasherize@if-flat__/__name@dasherize__.effects.ts
Outdated
Show resolved
Hide resolved
brandonroberts
requested changes
Feb 22, 2019
modules/schematics/src/effect/files/__name@dasherize@if-flat__/__name@dasherize__.effects.ts
Show resolved
Hide resolved
Make the generated effect for 'ng g feature' harmless by not dispatching any action type the 'Actions' injectable by default in effect Closes #1573
brandonroberts
requested changes
Feb 22, 2019
Collaborator
|
Preview docs changes for 9115c3e at https://previews.ngrx.io/pr1576-9115c3e/ |
brandonroberts
approved these changes
Feb 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two minor fixes for effects generated by
ng g feature:Closes #1573
PR Checklist
Please check if your PR fulfills the following requirements:
Documentation has been added / updated (for bug fixes / features)PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Other information