Schematics: Use MockStore in container generated tests

[jtcrowson]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/ngrx/platform/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Documentation has been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

• Container schematic uses StoreModule for unit tests

Closes #2028

What is the new behavior?

• Container schematic uses MockStore for unit tests
• testDepth option to use StoreModule for integration tests instead.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

[ngrxbot]

Preview docs changes for 68facda at https://previews.ngrx.io/pr2029-68facda/

[ngrxbot]

Preview docs changes for 689fc93 at https://previews.ngrx.io/pr2029-689fc93/

[brandonroberts]

What do you think about providing an option to generate an integration test vs a unit test instead of replacing it?

[jtcrowson]

I’m up for it. Should we use two separate options?
--spec=true|false, default: true (existing in angular/schematics)
--testDepth=unit|integration, default: unit (new for NgRx/schematics)

[brandonroberts]

👍

[ngrxbot]

Preview docs changes for 896899c at https://previews.ngrx.io/pr2029-896899c/

[jtcrowson]

@brandonroberts Added the testDepth option in 896899c and b696b66 👍

[ngrxbot]

Preview docs changes for b696b66 at https://previews.ngrx.io/pr2029-b696b66/

[timdeschryver]

@jtcrowson seems like a test is failing, could you have a look?
Besides this it LGTM 👍

[jtcrowson]

@brandonroberts just curious, why lowercase for the enums? Looks like angular uses uppercase for enums that are words.

🔗https://angular.io/cli/generate
Ex: viewEncapsulation, changeDetection, routingScope

[brandonroberts]

For the values? The key is testDepth in camel case, which matches the CLI, but the values are lowercase.

[brandonroberts]

I see it now. Its a mix. I'd rather keep the consistent with lowercase for the values.

[brandonroberts]

@jtcrowson will you check the failing unit tests?

[ngrxbot]

Preview docs changes for b088215 at https://previews.ngrx.io/pr2029-b088215/

[jtcrowson]

@brandonroberts sorry for the delay, I've been busy with Angular Denver stuff.

I update the integration/unit casing and made integration the default.

I'm having trouble debugging the test failures since I can't get yarn test:bazel running locally. The CircleCI print out isn't helping much either.

[brandonroberts]

No problem. I'll take a look at the test failures.

[ngrxbot]

Preview docs changes for d713cbe at https://previews.ngrx.io/pr2029-d713cbe/

[jtcrowson]

@brandonroberts thanks for d713cbe, makes sense why it was passing with jasmine locally but not with bazel.

[brandonroberts]

Yep, its weird that it just fails silently also, and doesn't generate the files if it doesn't find the path.