refactor(schematics): migrate from styleext to style#2254
Merged
brandonroberts merged 1 commit intongrx:masterfrom Jan 7, 2020
Merged
refactor(schematics): migrate from styleext to style#2254brandonroberts merged 1 commit intongrx:masterfrom
brandonroberts merged 1 commit intongrx:masterfrom
Conversation
Contributor
Author
|
cc: @timdeschryver |
Collaborator
|
Preview docs changes for 7110401 at https://previews.ngrx.io/pr2254-7110401/ |
timdeschryver
requested changes
Nov 13, 2019
Jefiozie
force-pushed
the
2248-style-options
branch
from
f8af310 to
5658d74
Compare
Contributor
Author
|
Okay, I don't exactly know why the bazel tests are failing. Is it because of my changes? |
Member
|
@Jefiozie a re-trigger of the CI solved it |
timdeschryver
requested changes
Nov 14, 2019
Member
timdeschryver
left a comment
timdeschryver
left a comment
There was a problem hiding this comment.
LGTM, just one minor remark
Jefiozie
force-pushed
the
2248-style-options
branch
from
5658d74 to
6f26dcc
Compare
Contributor
Author
|
Resolved the minor comment |
timdeschryver
approved these changes
Nov 14, 2019
Member
|
@Jefiozie could you also add a breaking change note to the PR please, you can find a template in CONTRIBUTING.MD |
Closes ngrx#2248 BREAKING CHANGES: To be inline with the Angular CLI, we migrated the `styleExt` to `style`. BEFORE: ``` "@schematics/angular:component": { "inlineStyle": true, "prefix": "aio", "styleext": "scss" } ... ``` AFTER: ``` "@schematics/angular:component": { "inlineStyle": true, "prefix": "aio", "style": "scss" } .... ```
Jefiozie
force-pushed
the
2248-style-options
branch
from
6f26dcc to
7110401
Compare
Contributor
Author
|
Added the requested breaking change notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Migration from
styleexttostyleWhat is the current behavior?
When setting the
styleyou can do this byng set default.styleext.Closes #2248
What is the new behavior?
With these changes, we are inline with the Angular CLI and you need the following command for setting the style
ng set default.styleDoes this PR introduce a breaking change?
Other information