Skip to content

fix(example): optimistically add/remove book from collection#2429

Merged
brandonroberts merged 1 commit intongrx:masterfrom
AdditionAddict:example/reducer
Mar 11, 2020
Merged

fix(example): optimistically add/remove book from collection#2429
brandonroberts merged 1 commit intongrx:masterfrom
AdditionAddict:example/reducer

Conversation

@AdditionAddict
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #2417

What is the new behavior?

Example app optimistically adds/removes book from collection

Does this PR introduce a breaking change?

[ ] Yes
[ x ] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Mar 8, 2020

Preview docs changes for d91742f at https://previews.ngrx.io/pr2429-d91742f/

@brandonroberts brandonroberts merged commit b0aacf7 into ngrx:master Mar 11, 2020
@AdditionAddict AdditionAddict deleted the example/reducer branch March 11, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

example-app - is removeBookFailure reducer correct?

5 participants