Skip to content

fix(router-store): selectors should return MemoizedSelector#2492

Merged
brandonroberts merged 1 commit intomasterfrom
pr/fix-router-selectors-types
Apr 18, 2020
Merged

fix(router-store): selectors should return MemoizedSelector#2492
brandonroberts merged 1 commit intomasterfrom
pr/fix-router-selectors-types

Conversation

@timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #2486

What is the new behavior?

Does this PR introduce a breaking change?

Could be a breaking change, if these types were being used

[ ] Yes
[ ] No

Other information

@joshuakeel
Copy link
Contributor

Thanks for working on this, @timdeschryver. 🤓

@brandonroberts brandonroberts merged commit 39a4b91 into master Apr 18, 2020
@timdeschryver timdeschryver deleted the pr/fix-router-selectors-types branch April 18, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Built-in router-store selectors can't be mocked

3 participants