Skip to content

feat(effects): allow multiple empty EffectModule.forRoot()#2774

Merged
brandonroberts merged 1 commit intomasterfrom
effect-guard
Nov 14, 2020
Merged

feat(effects): allow multiple empty EffectModule.forRoot()#2774
brandonroberts merged 1 commit intomasterfrom
effect-guard

Conversation

@alex-okrushko
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Allow multiple empty EffectModule.forRoot().
Within Google we have a number of cases with empty EffectModule.forRoot() have to be added for tests to be able to find this module - ngc has a hard time generating a summary for EffectsModule.forRoot otherwise.

Up until now, the solution was to just remove the guard altogether when merging NgRx locally, but that's not a sustainable approach and requires "un-doing" it with every merge.

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants