Update feature_creator.ts#3198
Merged
brandonroberts merged 2 commits intongrx:masterfrom Oct 23, 2021
Merged
Conversation
Fixing feature creator to use the version of createFeatureSelector without the RootState.
Collaborator
|
Preview docs changes for 22cc646 at https://previews.ngrx.io/pr3198-22cc6461/ |
Member
timdeschryver
left a comment
There was a problem hiding this comment.
It would be great, if we can refactor all these usages.
If I'm not mistaken, there are 2 usages left after this one, both in the examples.
You can search for export const selectCollectionState = createFeatureSelector< and you'll find them.
Could you add these to this PR please?
Contributor
Author
|
@timdeschryver updated the two instances I found |
timdeschryver
approved these changes
Oct 23, 2021
brandonroberts
approved these changes
Oct 23, 2021
This was referenced Nov 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing feature creator to use the version of createFeatureSelector without the RootState.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Uses the createFeatureSelector version that uses RootState which conflicts with the recommended usage.
Closes #3197
What is the new behavior?
Does this PR introduce a breaking change?
Other information