feat(router-store): remove deprecated getSelectors method#3816
Merged
brandonroberts merged 1 commit intongrx:masterfrom Apr 15, 2023
Merged
Conversation
Removes deprecated getSelectors method from router-store Closes ngrx#3813
✅ Deploy Preview for ngrx-io canceled.Built without sensitive environment variables
|
Contributor
Author
|
This is my first OS contribution, just as a disclaimer 😄 |
markostanimirovic
approved these changes
Mar 29, 2023
timdeschryver
approved these changes
Mar 30, 2023
Member
timdeschryver
left a comment
There was a problem hiding this comment.
Congratulations on your first contribution, that's awesome to hear! 🏆
Member
|
Thanks @apramendorfer, nice work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes deprecated getSelectors method from router-store
Closes #3813
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #3815
What is the new behavior?
The deprecated method getSelectors is removed from router-store
Does this PR introduce a breaking change?
Other information
Migration script for the renaming of the method is already in place.