feat(material): Upgrade @angular/material to v 2.0.0-beta.12#482
feat(material): Upgrade @angular/material to v 2.0.0-beta.12#482krjordan merged 2 commits intongrx:masterfrom
Conversation
| <mat-input-container> | ||
| <input matInput placeholder="Search for a book" [value]="query" (keyup)="search.emit($event.target.value)"> | ||
| </mat-input-container> | ||
| <mat-progress-spinner mode="indeterminate" [class.show]="searching"></mat-progress-spinner> |
There was a problem hiding this comment.
Instead of using mat-progress-spinner you can use the mat-spinner. The <mat-spinner> component is an alias for <mat-progress-spinner mode="indeterminate">. You should also add the diameter and strokeWidth inputs. This will allow us to not have to use !important when setting the width and height. It should look something like:
<mat-spinner [class.show]="searching" [diameter]="30" [strokeWidth]="3"></mat-spinner>
There was a problem hiding this comment.
great i was struggling to set the correct values for this :)
| height: 30px; | ||
| .mat-progress-spinner { | ||
| width: 30px !important; | ||
| height: 30px !important; |
There was a problem hiding this comment.
Remove the width and height
| overflow: auto; | ||
| } | ||
|
|
||
| .mat-progress-spinner svg { |
There was a problem hiding this comment.
This is no longer needed after fixing the book-search component.
package.json
Outdated
| "@angular/forms": "^4.2.0", | ||
| "@angular/http": "^4.2.0", | ||
| "@angular/material": "^2.0.0-beta.7", | ||
| "@angular/material": "^2.0.0-beta.12", |
There was a problem hiding this comment.
We should lock this to version 2.0.0-beta.12 so it won't break if a new release is published with breaking changes.
| }, | ||
| "dependencies": { | ||
| "@angular/cdk": "^2.0.0-beta.8", | ||
| "@angular/cdk": "^2.0.0-beta.12", |
There was a problem hiding this comment.
We should lock this to version 2.0.0-beta.12 so it won't break if a new release is published with breaking changes. This can probably also be moved to the devDependencies.
setup-jest.ts
Outdated
| import 'jest-preset-angular'; | ||
| import { MdCommonModule } from '@angular/material'; | ||
|
|
||
| // import { MdCommonModule } from '@angular/material'; |
There was a problem hiding this comment.
These should be deleted instead of commented out.
izifortune
force-pushed
the
feature/upgrade-angular-material
branch
from
b0d6297 to
b21c54b
Compare
izifortune
force-pushed
the
feature/upgrade-angular-material
branch
from
b21c54b to
d8b7a81
Compare
Angular material removed the global MaterialModule all the components needs to be imported individually. Fixes ngrx#448
|
All comments addressed |
| overflow: auto; | ||
| } | ||
|
|
||
| .mat-progress-spinner svg { |
There was a problem hiding this comment.
Can you remove this block? It's no longer needed.
| }, | ||
| "dependencies": { | ||
| "@angular/cdk": "^2.0.0-beta.8", | ||
| "@angular/cdk": "^2.0.0-beta.12", |
There was a problem hiding this comment.
We should lock this to version 2.0.0-beta.12 so it won't break if a new release is published with breaking changes. This can probably also be moved to the devDependencies.
3 participants
Angular material removed the global MaterialModule all the
components needs to be imported individually.
Fixes #448