fix(schematics): use inject in generated data, effect, and component-store templates - #5142
Merged
markostanimirovic merged 4 commits intoApr 13, 2026
Merged
Conversation
✅ Deploy Preview for ngrx-io ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
slang123
force-pushed
the
fix/schematics-use-inject-5136
branch
from
April 7, 2026 22:00
a083b1d to
b56287d
Compare
slang123
force-pushed
the
fix/schematics-use-inject-5136
branch
from
April 7, 2026 22:04
b56287d to
7d3679b
Compare
timdeschryver
left a comment
timdeschryver
left a comment
Member
There was a problem hiding this comment.
Looks good to me, just one question.
markostanimirovic
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:
What is the current behavior?
Schematic templates currently generate constructor-based DI in some outputs (
data,effect, andcomponent-store) instead of usinginject(...).Closes #5136
What is the new behavior?
Updated schematic templates to generate
inject(...)-based DI:datatemplate now usesinject(EntityCollectionServiceElementsFactory)in thesuper(...)call.effecttemplate now usesprivate actions$ = inject(Actions)instead of constructor injection.component-storetemplate was updated to useinject(...)-based initialization.Does this PR introduce a breaking change?
[ ] Yes
[x] No
Other information
Changes are scoped to
@ngrx/schematicstemplate output and snapshot expectations.