Skip to content

Add middlewares#34

Merged
saitonakamura merged 5 commits into
nickovchinnikov:masterfrom
saitonakamura:lesson-17
Jun 1, 2020
Merged

Add middlewares#34
saitonakamura merged 5 commits into
nickovchinnikov:masterfrom
saitonakamura:lesson-17

Conversation

@saitonakamura
Copy link
Copy Markdown
Contributor

@saitonakamura saitonakamura commented Jun 1, 2020

No description provided.

nickovchinnikov
nickovchinnikov reviewed Jun 1, 2020
View reviewed changes
Comment thread package.json Outdated
nickovchinnikov
nickovchinnikov reviewed Jun 1, 2020
View reviewed changes
Comment thread src/rdx/store.ts Outdated
@nickovchinnikov nickovchinnikov self-requested a review June 1, 2020 09:51
@nickovchinnikov
Copy link
Copy Markdown
Owner

nickovchinnikov commented Jun 1, 2020

А кроме того, чтобы добавить в проект, будут какие то примеры в крестиках-ноликах?

nickovchinnikov
nickovchinnikov requested changes Jun 1, 2020
View reviewed changes
Copy link
Copy Markdown
Owner

@nickovchinnikov nickovchinnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Очень уместно обновить readme.md

vvscode
vvscode reviewed Jun 1, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@vvscode vvscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а как написать свой логгер ты им покажешь?

Comment thread package.json
@saitonakamura
Copy link
Copy Markdown
Contributor Author

saitonakamura commented Jun 1, 2020

Логгер будем писать на занятии в кодсендбоксе

@saitonakamura
Copy link
Copy Markdown
Contributor Author

saitonakamura commented Jun 1, 2020 •
edited
Loading

Очень уместно обновить readme.md

Да, сейчас сделаю пр с домашкой и вот

@saitonakamura
Copy link
Copy Markdown
Contributor Author

saitonakamura commented Jun 1, 2020 •
edited
Loading

А кроме того, чтобы добавить в проект, будут какие то примеры в крестиках-ноликах?

Нет, мне не хватило времени вписать это

@nickovchinnikov
Copy link
Copy Markdown
Owner

nickovchinnikov commented Jun 1, 2020

Нет, мне не хватило времени вписать это

один экшен сделать асинхронным с setTimeout?

@saitonakamura
Copy link
Copy Markdown
Contributor Author

saitonakamura commented Jun 1, 2020 •
edited
Loading

один экшен сделать асинхронным с setTimeout?

есть пример под рукой?

@nickovchinnikov
Copy link
Copy Markdown
Owner

nickovchinnikov commented Jun 1, 2020

какой например

поставить метку в поле?

nickovchinnikov
nickovchinnikov reviewed Jun 1, 2020
View reviewed changes
Comment thread README.md
* Redux middlewares

[Pull request](https://github.com/nickovchinnikov/react-js-tutorial/pull/34) <br>
[Homework](https://github.com/nickovchinnikov/react-js-tutorial/pull/35) <br>
Copy link
Copy Markdown
Owner

@nickovchinnikov nickovchinnikov Jun 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это дополнительная ДЗ, к той что в кабинете?

Copy link
Copy Markdown
Contributor Author

@saitonakamura saitonakamura Jun 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нет, я обновил ту что в кабинете на эту

@saitonakamura
Copy link
Copy Markdown
Contributor Author

saitonakamura commented Jun 1, 2020

поставить метку в поле?

сделал

@saitonakamura saitonakamura merged commit efebce9 into nickovchinnikov:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vvscode vvscode vvscode left review comments

@nickovchinnikov nickovchinnikov nickovchinnikov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@saitonakamura @nickovchinnikov @vvscode