Clean up the IDE Inspect Code warnings#34
Open
LahaLuhem wants to merge 10 commits into
Open
Conversation
Redundant, unused, when subject, unnecessary Anys, imports + symbols
Unused properties
Unused params
unused schema declaration, attribute is not allowed
JUnit API usage from multiple versions in a single TestCase -> @test annotation
missing lang-attribute (accessibility)
Experimental API
Style -> Unused version catalog entry
| <ExternalSystemReattachDebugProcess>true</ExternalSystemReattachDebugProcess> | ||
| <ExternalSystemDebugDisabled>false</ExternalSystemDebugDisabled> | ||
| <EXTENSION ID="com.intellij.execution.ExternalSystemRunConfigurationJavaExtension"> | ||
| <extension name="com.fapiko.jetbrains.plugins.better_direnv.runconfigs.IdeaRunConfigurationExtension"> |
Owner
There was a problem hiding this comment.
What is that?
Why this file is needed? There is gradle to run tests.
Contributor
Author
There was a problem hiding this comment.
If you open it in Intellij, this config was added by default, auto-detected by the IDE? It adds a nice 'Click to run' for Intellij users. I think anyone opening the project in Intellij would auto-generate this locally anyways. So if you want, I could remove it and add to .gitignore?
Owner
There was a problem hiding this comment.
Yes please. It looks strange, idea shouldn't add such. Over than that the PR looks nice!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Went through the IDE's Inspect Code results and cleared them out, one group at a time. No behaviour changes here, just dead code, redundant bits, and stale config removed.
Mostly they are IDE-assisted directly
Cleanups
KtLanguageVisitor, tidied the settings and visitor classesCachedSingletonsRegistrywith a plain service lookup, moved the experimental-API suppressions to file level with a reasonMight need more atttention
CachedSingletonsRegistryis gone. It's marked@ApiStatus.Internal, so it was never really ours to use. Swapped it forSettingsState.INSTANCE(the platform caches services already), which kills the warning at the source instead of supressing it.@Suppress("UnstableApiUsage")now sit as one@file:annotation per file, each with a one-line note on why it's there (no stable API yet, so it stays until there is one).annotations,dokka,gradleIntelliJPlugin,kover,qodana) weren't referenced anywhere.gradleIntelliJPluginwas a leftover from the 1.x to 2.x plugin migration.Attachments
Here are the original (baseline) exported warnings:
report_2026-06-24.sarif.json
report_2026-06-24.html.zip (quick view in browser)