Merged
Conversation
Contributor
Author
|
Unrelated? |
Member
Yes, it was there before. We need to look into that separately. |
Member
|
I'm merging this, other CI failures can be fixed later. |
arnetheduck
reviewed
Jul 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So this PR add smartptrs after passing a review round here nim-lang/Nim#18450
They now depend on new atomics #4 Other changes include the addition of
newSharePtr/newUniquePtrwithout data parameter and the accompanying[]=overloads. As discussed nim-lang/Nim#18450 (comment)Bug planetis-m/sync#13 affects pointers that contain ref objects, only when the user tries to reference them in a local variable
let a: ref Foo = mysharedptr[]not sure how to disallow this.