Skip to content

Feat(deps): forked finale#20

Merged
noahehall merged 4 commits intonirvlifefrom
feat/forked-finale
Jun 10, 2023
Merged

Feat(deps): forked finale#20
noahehall merged 4 commits intonirvlifefrom
feat/forked-finale

Conversation

@noahehall
Copy link
Copy Markdown
Contributor

@noahehall noahehall commented May 29, 2023

C

  • we spent a a bunch of time forking react-ideal-image and react-fullerpage
  • lets cleanup some rough edges found in testing
  • unfortunately without react-cosmos (or something similar) using this app is the most efficient way fo testing them

T

  • setup turbo build
    • turbo doesnt work with bun
$ bunx turbo run dev:nirvlife
Error: We did not find a package manager specified in your root package.json. Please set the "packageManager" property in your root package.json (https://nodejs.org/api/packages.html#packagemanager) or run `npx @turbo/codemod add-package-manager` in the root of your monorepo.
  • react-fullerpage
    • the scrolling isnt silky smooth, needs another review
  • react-ideal-image
    • dont show click to download on Initial, it looks weird

A

@noahehall noahehall changed the base branch from develop to nirvlife May 29, 2023 11:19
@noahehall noahehall force-pushed the feat/forked-finale branch 3 times, most recently from 0324b4e to 351b61b Compare May 29, 2023 21:19
@noahehall noahehall force-pushed the feat/forked-finale branch from 351b61b to aab487b Compare May 30, 2023 00:37
@noahehall noahehall force-pushed the feat/forked-finale branch from 316ae63 to 555fadc Compare June 4, 2023 02:21
@noahehall noahehall force-pushed the feat/forked-finale branch 2 times, most recently from 8d52099 to 3be5316 Compare June 10, 2023 01:42
@noahehall noahehall force-pushed the feat/forked-finale branch from 3be5316 to c55c13a Compare June 10, 2023 01:54
@noahehall
Copy link
Copy Markdown
Contributor Author

this PR is no longer required as react-cosmos works with bun and we no longer need a container app to develop the forks ;)

@noahehall noahehall merged commit 102d32c into nirvlife Jun 10, 2023
@noahehall noahehall deleted the feat/forked-finale branch June 10, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant