fix: call rollup:before before generating rollup config#335
Merged
Conversation
This was referenced Jul 12, 2022
pi0
reviewed
Jul 12, 2022
| export async function build (nitro: Nitro) { | ||
| const rollupConfig = getRollupConfig(nitro) | ||
| await nitro.hooks.callHook('rollup:before', nitro) | ||
| const rollupConfig = getRollupConfig(nitro) |
Member
There was a problem hiding this comment.
I think put hook before to allow extending resolved config but not possible. We can use new hook for that :)
pi0
approved these changes
Jul 12, 2022
pi0
added a commit
that referenced
this pull request
Jul 12, 2022
This opens an unseen bug in nuxt < rc.4. including in a later semver-major version
WinterYukky
pushed a commit
to WinterYukky/nitro
that referenced
this pull request
Nov 1, 2022
WinterYukky
pushed a commit
to WinterYukky/nitro
that referenced
this pull request
Nov 1, 2022
This opens an unseen bug in nuxt < rc.4. including in a later semver-major version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
nuxt/content#1346 (comment)
❓ Type of change
📚 Description
Likely in
rollup:beforeusers might want to modify nitro options with effect of changing rollup config. For example:https://github.com/nuxt/framework/blob/f321a56e63be508e5f478b1de5227a5add2b977f/packages/nuxt/src/core/nitro.ts#L124-L134
This makes that possible.
📝 Checklist